Package Details: brave 0.19.134-1

Git Clone URL: https://aur.archlinux.org/brave.git (read-only)
Package Base: brave
Description: Web browser that blocks ads and trackers by default.
Upstream URL: https://www.brave.com/
Keywords: browser muon web
Licenses: custom
Provides: brave-browser
Submitter: mischka
Maintainer: mischka (vorbote)
Last Packager: mischka
Votes: 42
Popularity: 2.505486
First Submitted: 2016-01-29 19:47
Last Updated: 2018-01-14 04:59

Dependencies (12)

Required by (0)

Sources (1)

Pinned Comments

mischka commented on 2018-01-16 14:34

This package currently does not build from a source tarball. Please use brave-bin or brave-git in the meantime. Not sure when this started happening, as it succeeds if it's run from within a git repo, which it always happened to be for me.

Issue raised upstream: https://github.com/brave/browser-laptop/issues/12667

Latest Comments

alexz commented on 2018-01-18 01:21

I see ... then, there is no other option but to fix that issue #12667

mischka commented on 2018-01-16 17:17

I would like to avoid that, that tarball looks to be a built binary, which is what brave-bin is for.

alexz commented on 2018-01-16 17:15

brave-git works for me. I'll try to fix this package and provide with a patch. The main idea is build from Brave.tar.bz2 instead of the src tarball. What do you think?

As a heads up to:

pkgname=brave
pkgver=0.19.134dev
component=browser-laptop

source=("${pkgname}-v${pkgver}.tar.bz2::https://github.com/${pkgname}/${component}/releases/download/v${pkgver}/Brave.tar.bz2")

sha512sums=("6d44be41542f4d21174bf8cb38e4352af997ab4177788b48d4090102891f5cb49d22a25dfc0f55816d3b63a53cf86efa26c4748b4e461a27bd82557144b3da2f") md5sums=('bbdabb80c4a25a0d16f6d70feafe8625')

build() and package() need to change accordingly.

mischka commented on 2018-01-16 14:34

This package currently does not build from a source tarball. Please use brave-bin or brave-git in the meantime. Not sure when this started happening, as it succeeds if it's run from within a git repo, which it always happened to be for me.

Issue raised upstream: https://github.com/brave/browser-laptop/issues/12667

mischka commented on 2018-01-16 13:44

@alexz Hm I'm sorry, I'm not sure what the issue is. It seems to work correctly for me on every computer I try it on. Could you try using makepkg directly instead of yaourt to see if that makes any difference?

Any additional help getting to the bottom of it would be appreciated!

Edit: It seems yaourt does seem to be the problem somehow, I tried using it instead of makepkg directly and ran into the same error. I'm looking into it but any help would still be appreciated!

alexz commented on 2018-01-15 23:04

Latest stable version is indeed: v0.19.134dev (more: https://github.com/brave/browser-laptop/releases/tag/v0.19.134dev)

However, probably the same issue as bellow: no git repository found

more:

Writing buildConfig.js...
/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:47
    throw new Error('[git-rev-sync] no git repository found');
    ^

Error: [git-rev-sync] no git repository found at _getGitDirectory (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:47:11) at _getGitDirectory (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:75:10) at _getGitDirectory (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:75:10) at branch (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:79:16) at Object.long (/tmp/yaourt-tmp-alex/aur-brave/src/browser-laptop-0.19.134dev/node_modules/git-rev-sync/index.js:92:11) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! brave@0.19.134 build-package: node ./tools/buildPackage.js npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the brave@0.19.134 build-package script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! /home/alex/.npm/_logs/2018-01-15T23_02_38_368Z-debug.log ==> ERROR: A failure occurred in build(). Aborting... ==> ERROR: Makepkg was unable to build brave. ==> Restart building brave ? [y/N]

mdl054 commented on 2017-12-07 02:16

Errors here still, unable to build

at Object.long (/tmp/yaourt-tmp-matt/aur-brave/src/browser-laptop-0.19.105dev/node_modules/git-rev-sync/index.js:92:11) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! brave@0.19.105 build-package: node ./tools/buildPackage.js npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the brave@0.19.105 build-package script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! /home/matt/.npm/_logs/2017-12-07T02_16_24_139Z-debug.log ==> ERROR: A failure occurred in build(). Aborting... ==> ERROR: Makepkg was unable to build brave. ==> Restart building brave ? [y/N]

rican-linux commented on 2017-12-04 02:32

The errors are resolved with the latest version!

rican-linux commented on 2017-11-28 01:46

I also have the same errors that @FreelancePolice. I reported it upstream here: https://github.com/brave/browser-laptop/issues/12114

mischka commented on 2017-11-04 19:09

Hm. Are you sure that the installation is being run with your globally installed node and not some lower version that's in your path (installed via nvm maybe)?

I believe node's strictness checking that returns those errors shouldn't be an issue after about v7.5.

All comments